Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-release: fill RELATED_IMAGE_AUTHORINO #230

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.54%. Comparing base (ee36d38) to head (3b68073).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   61.54%   61.54%           
=======================================
  Files           2        2           
  Lines         788      788           
=======================================
  Hits          485      485           
  Misses        251      251           
  Partials       52       52           
Flag Coverage Δ
unit 61.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
@eguzki
Copy link
Contributor Author

eguzki commented Nov 19, 2024

Weird, some unrelated changes show up in the bundle and helm charts 🤷

requests:
cpu: 200m
memory: 200Mi
- command:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is expected as now yq is formatting the manager.yaml

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can see the env var being updated (in both the config/manager and CSV):

AUTHORINO_VERSION=v0.19.0 make bundle
   env:
     - name: RELATED_IMAGE_AUTHORINO
-      value: quay.io/kuadrant/authorino:latest
+      value: quay.io/kuadrant/authorino:v0.19.0

@eguzki eguzki merged commit bc80c97 into main Nov 19, 2024
11 checks passed
@eguzki eguzki deleted the fix-prepare-release branch November 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants