-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare-release: fill RELATED_IMAGE_AUTHORINO #230
Conversation
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 61.54% 61.54%
=======================================
Files 2 2
Lines 788 788
=======================================
Hits 485 485
Misses 251 251
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Weird, some unrelated changes show up in the bundle and helm charts 🤷 |
requests: | ||
cpu: 200m | ||
memory: 200Mi | ||
- command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is expected as now yq
is formatting the manager.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can see the env var being updated (in both the config/manager and CSV):
AUTHORINO_VERSION=v0.19.0 make bundle
env:
- name: RELATED_IMAGE_AUTHORINO
- value: quay.io/kuadrant/authorino:latest
+ value: quay.io/kuadrant/authorino:v0.19.0
No description provided.