Check 'client auth' key usage on mtls identity #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
force-pushed
the
mtls-require-ext-client-auth
branch
from
8f61f74 to
f896219
Compare
guicassolato
force-pushed
the
mtls-require-ext-client-auth
branch
2 times, most recently
from
ca9d923 to
96dcd46
Compare
guicassolato
added
kind/enhancement
KevFan
reviewed
Feb 2, 2024
Make the mTLS identity verification method to check for 'client auth' extended key usage, instead of default 'server auth'.
guicassolato
force-pushed
the
mtls-require-ext-client-auth
branch
from
96dcd46 to
a0b013d
Compare
@KevFan, with which version of Authorino did you run the guide? The guide was written (including with the changes in this PR) assuming that it will work after we merge the PR. This is because in the PR we're also changing the code that make the guide work of course. To try the guide before merging the PR, you should start with Please let me know if this works for you. |
KevFan
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
@guicassolato Oh, that was it 👍 Ran through the guide again and works as expected ! 🎖️
Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the mTLS identity verification method to check for 'Client authentication' extended key usage, instead of default 'Server authentication' (ref).