Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky tests #436

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: flaky tests #436

merged 2 commits into from
Oct 17, 2023

Conversation

guicassolato
Copy link
Collaborator

  • authconfig conversion tests with random orderring of elements within array
  • weak concurrency coordination using sleep directive

Popped up more often after #435.

@guicassolato guicassolato self-assigned this Oct 16, 2023
@guicassolato guicassolato marked this pull request as ready for review October 16, 2023 11:31
@guicassolato guicassolato requested a review from a team October 16, 2023 11:31
Boomatang
Boomatang approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straight forward and good to me, as this is fixing flaky tests I guess time will tell if it resolves the issue.

@guicassolato guicassolato merged commit e1d433a into main Oct 17, 2023
9 checks passed
@guicassolato guicassolato deleted the fix-flaky-tests branch October 17, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boomatang Boomatang Boomatang approved these changes

Assignees

@guicassolato guicassolato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicassolato @Boomatang