-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce AuthConfig v1beta3 #493
Conversation
Signed-off-by: KevFan <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta3/authconfig.yaml | View secret |
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta1/authconfig.yaml | View secret |
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta1/authconfig.yaml | View secret |
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta1/authconfig.yaml | View secret |
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta3/authconfig.yaml | View secret |
8184017 | Triggered | Keycloak Api Keys | ebe9c80 | tests/v1beta3/authconfig.yaml | View secret |
8184018 | Triggered | Elliptic Curve Private Key | ebe9c80 | tests/v1beta3/authconfig.yaml | View secret |
8184018 | Triggered | Elliptic Curve Private Key | ebe9c80 | tests/v1beta1/authconfig.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: KevFan <[email protected]>
Signed-off-by: KevFan <[email protected]>
@guicassolato I forget what we decided, do we want v1beta3 as the stored version immediately and move the code to depend on these types given that it's a straight copy of v1beta2 at the moment? 🤔 |
I think so, @KevFan. Since the last released version of Authorino already made v1beta2 the stored version, users can count on a migration path all the way from v1beta1 (deprecated) to latest v1beta3 (about to become the stored version in the next release). |
Signed-off-by: KevFan <[email protected]>
Signed-off-by: KevFan <[email protected]>
e2e tests passed - https://github.com/Kuadrant/authorino/actions/runs/11275567041 |
Description
Closes: #480
Introduces AuthConfig v1beta3 and uses it as the storaged version in preparation for upcoming api changes. Currently it is straight copy of v1beta2, so removes the need of the conversion webhook. v1beta1 has been completely removed and docs have been updated to reference v1beta3
TODOs
Remove deloying authorino-operator webhook