Skip to content

Commit

Permalink
fix: Multi record test
Browse files Browse the repository at this point in the history
Test was incorrectly checking for "GEO-" in the aws provider specific
endpoint values.

Signed-off-by: Michael Nairn <[email protected]>
  • Loading branch information
mikenairn committed Nov 7, 2024
1 parent ded3614 commit 5b3a166
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/e2e/multi_record_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,7 @@ var _ = Describe("Multi Record Test", Labels{"multi_record"}, func() {
if !provider.IsISO3166Alpha2Code(geoCode) {
awsGeoCodeKey = "aws/geolocation-continent-code"
}
awsGeoCodeValue := strings.TrimPrefix(geoCode, "GEO-")

Expect(zoneEndpoints).To(ContainElement(PointTo(MatchFields(IgnoreExtras, Fields{
"DNSName": Equal(klbHostName),
Expand All @@ -621,7 +622,7 @@ var _ = Describe("Multi Record Test", Labels{"multi_record"}, func() {
"RecordTTL": Equal(externaldnsendpoint.TTL(300)),
"ProviderSpecific": Equal(externaldnsendpoint.ProviderSpecific{
{Name: "alias", Value: "false"},
{Name: awsGeoCodeKey, Value: geoCode},
{Name: awsGeoCodeKey, Value: awsGeoCodeValue},
}),
}))))
totalEndpointsChecked++
Expand All @@ -633,7 +634,7 @@ var _ = Describe("Multi Record Test", Labels{"multi_record"}, func() {
"SetIdentifier": Equal(geoCode),
"RecordTTL": Equal(externaldnsendpoint.TTL(300)),
"ProviderSpecific": Equal(externaldnsendpoint.ProviderSpecific{
{Name: awsGeoCodeKey, Value: geoCode},
{Name: awsGeoCodeKey, Value: awsGeoCodeValue},
}),
}))))
totalEndpointsChecked++
Expand Down

0 comments on commit 5b3a166

Please sign in to comment.