expect wildcard endpoint

Kuadrant · Mar 12, 2024 · 9214e66 · 9214e66
1 parent 5bfb02e
commit 9214e66
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/api/v1alpha1/dnsrecord_types.go b/api/v1alpha1/dnsrecord_types.go
@@ -135,12 +135,13 @@ func (s *DNSRecord) Validate() error {
 				return fmt.Errorf("invalid endpoint discovered %s all endpoints should be equal to or end with the rootHost %s", ep.DNSName, root)
 			}
 			if !rootEndpointFound {
-				if ep.DNSName == root {
+				//check original root
+				if ep.DNSName == *s.Spec.RootHost {
 					rootEndpointFound = true
 				}
 			}
 		}
-		if !rootEndpointFound && !s.isWildCardRoot() {
+		if !rootEndpointFound {
 			return fmt.Errorf("invalid endpoint set. rootHost is set but found no endpoint defining a record for the rootHost %s", root)
 		}
 	}

diff --git a/api/v1alpha1/dnsrecord_types_test.go b/api/v1alpha1/dnsrecord_types_test.go
@@ -65,7 +65,7 @@ func TestValidate(t *testing.T) {
 				"a.example.com",
 				"b.example.com",
 			},
-			wantErr: false,
+			wantErr: true,
 		},
 	}