Make ownerID and rootHost required in record spec #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the DNSRecord spec to make `ownerID` and `rootHost` required. We might in the future decide to change this, but for now this is the most tested path and what is required for the kuadrant DNSPolicy. This will also prevent a situation where a DNSRecord could be created that can unexpectedly remove unrelated records from a zone. Adds minimal validation to the fields, length > 1 for both `ownerID` and `rootHost` and a max length of 12 for `ownerID`.
Signed-off-by: Michael Nairn <[email protected]>
philbrookes
approved these changes
May 8, 2024
Signed-off-by: Michael Nairn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101
Updates the DNSRecord spec to make
ownerIDandrootHostrequired. We might in the future decide to change this, but for now this is the most tested path and what is required for the kuadrant DNSPolicy. This will also prevent a situation where a DNSRecord could be created that can unexpectedly remove unrelated records from a zone.Adds minimal validation to the fields, length > 1 for both
ownerIDandrootHostand a max length of 12 forownerID.Follow on issues/discussions: