Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding health check e2e tests #113

Merged
merged 1 commit into from
May 15, 2024
Merged

adding health check e2e tests #113

merged 1 commit into from
May 15, 2024

Conversation

philbrookes
Copy link
Contributor

No description provided.

@philbrookes philbrookes force-pushed the gh-92 branch 5 times, most recently from 74ceeb9 to 9af8133 Compare May 9, 2024 20:22
@philbrookes philbrookes changed the title [WIP] adding health check e2e tests adding health check e2e tests May 10, 2024
@philbrookes philbrookes force-pushed the gh-92 branch 2 times, most recently from d3a91c7 to dc6f9dd Compare May 10, 2024 10:26
@philbrookes philbrookes force-pushed the gh-92 branch 2 times, most recently from 69e142c to 22744a7 Compare May 13, 2024 08:35
@philbrookes philbrookes force-pushed the gh-92 branch 2 times, most recently from b31f083 to b50bb14 Compare May 14, 2024 08:32
@philbrookes philbrookes force-pushed the gh-92 branch 2 times, most recently from 7cbdaf1 to 34c12e1 Compare May 14, 2024 09:36
@mikenairn
Copy link
Member

@philbrookes This doesn't appear to be creating any health checks, tests pass even when there are errors:

{
	"lastTransitionTime": "2024-05-14T10:44:45Z",
	"message": "probe (id: , address: 172.32.200.1, host: t-single-proud-glitter.dns-op-e2e-dawn-sun.mn.hcpapps.net) error from DNS Provider: A different health check has already been created with the specified caller reference. If that health check has been deleted, Route 53 will still maintain the caller reference for a number of days.",
	"reason": "DNSProviderError",
	"status": "False",
	"type": "ProbeSynced"
}

mikenairn
mikenairn reviewed May 14, 2024
View reviewed changes
test/e2e/suite_test.go Outdated Show resolved Hide resolved
@philbrookes philbrookes force-pushed the gh-92 branch 2 times, most recently from 44a3505 to 274f6b8 Compare May 14, 2024 12:35
mikenairn
mikenairn approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally, it does create health checks now.

Question about the HealthCheckExists function, does it even work? but if it is, changes look fine to me.

@philbrookes philbrookes added this pull request to the merge queue May 15, 2024
Merged via the queue into Kuadrant:main with commit 9ed49a9 May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenairn mikenairn mikenairn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philbrookes @mikenairn