Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #102
What
external-dns: aws provider return zone errors
Update provider SanitizeError
Update provider SanitizeError function to better handle aws errors, removes status code, newlines, tabs, and sax parsers exceptions from the returned error.
tests: Add provider errors e2e specs
Adds a provider errors set of specs to the e2e test suite. The purpose of this is to test each supported provider returns a reasonable response and updates the record status appropriately in cases where a user can misconfigure a DNSRecord and cause a provider error. These mainly focus on what can be set from the DNSPolicy (geo and weight) and the intention isn't to exhaustively test all error scenarios.
Added as an e2e test since this can, and will be, different on every provider. Tests also ensure that the records are not falling into a loop of constantly being updated when a provider error is updating the status.
Requires: