ci: on release check version string is the expected one

[eguzki]

What

Follow up work from #274

CI check to ensure release version in go code matches git version tag

Release version passed in by ldflag

Verification steps: create a release that should succeed.

git checkout -b release-0.7-testing ci-update-check-version-string

Run prepare release for final version v0.0.100.

make prepare-release VERSION=0.0.100 CHANNELS=stable REPLACES_VERSION=0.6.0

Verify local changes, commit, push and tag with the typo:

git add .
git commit -m "prepare-release: v0.7.0"
git tag v0.0.100 
git push origin release-0.7-testing
git push origin v0.0.100 

Verify that the build image for release tag workflow is triggered and completes for the new tag

• Clean up

git checkout ci-update-check-version-string
git push --delete origin v0.0.100
git tag -d v0.0.100
git push --delete origin release-0.7-testing
git branch -D release-0.7-testing

Verification steps: create a release that should fail.

Let's prepare a release with a typo.

git checkout -b release-0.7-testing ci-update-check-version-string

Run prepare release for final version v0.0.200.

make prepare-release VERSION=0.0.200 CHANNELS=stable REPLACES_VERSION=0.6.0

Verify local changes, commit, push and tag with one typo: instead of tag v0.0.200 which would be the right one, tag it with v0.0.201.

git add .
git commit -m "prepare-release: v0.7.0"
git tag v0.0.201
git push origin release-0.7-testing
git push origin v0.0.201

Verify that the build image for release tag workflow is triggered and fails.

Checking CI logs

Git reference name = v0.0.201, release version = v0.0.200

So, the step named Verify git reference name matches the release version should fail.

• Clean up

git checkout ci-update-check-version-string
git push --delete origin v0.0.201
git tag -d v0.0.201
git push --delete origin release-0.7-testing
git branch -D release-0.7-testing

[mikenairn]

👍 Using the single version from the makefile makes sense to me. On release branches we set this as an override as part of the release process https://github.com/Kuadrant/dns-operator/blob/v0.6.0/make/release.mk#L7

[eguzki]

I know :)

I think that I will bring this release.mk approach to the other projects