update probe logic not to share memory #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
maleck13
force-pushed
the
update-prob-logic
branch
from
7b3f2e0 to
4af3023
Compare
| @@ -182,7 +149,7 @@ func (w *Probe) performRequest(ctx context.Context, protocol, host, path, ip str | |||
| httpReq.Header.Add(h.Name, h.Value) | |||
| } | |||
|
|
|||
| logger.V(1).Info("health: probe executing against ", "url", httpReq.URL) | |||
| logger.V(2).Info("health: probe executing against ", "url", httpReq.URL) | |||
There was a problem hiding this comment.
If I remember correctly the V(2) level cannot be displayed with the way we implemented a logger. It is log.Info for info log.V(1).info for debug level and log.Error() and log.V(1).Error for error level logs. Byt setting it to V(2) we unable to display them 🤔
|
@maksymvavilov setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with
--raceshowed we were sharing some memory across routines. I have adjusted the design not to share memory like this nowSigned-off-by: craig [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED