remove writing out lastCheckedAt status #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleck13
force-pushed
the
remove-last-checked
branch
2 times, most recently
from
682db9c to
8ea0c47
Compare
Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
maleck13
force-pushed
the
remove-last-checked
branch
from
8ea0c47 to
db6233f
Compare
| @@ -246,11 +252,11 @@ func (w *Probe) Start(clientctx context.Context, k8sClient client.Client, probe | |||
| } else { | |||
| freshProbe.Status.ConsecutiveFailures = 0 | |||
| } | |||
| logger.V(1).Info("health: execution complete ", "result", probeResult, "checked at", probeResult.CheckedAt.String(), "previoud check at ", probeResult.PreviousCheck) | |||
| freshProbe.Status.Healthy = &probeResult.Healthy | |||
| freshProbe.Status.LastCheckedAt = probeResult.CheckedAt | |||
There was a problem hiding this comment.
We probably should not write LastCheckedAt to the probe CR anymore
| @@ -26,10 +26,13 @@ const ( | |||
| ) | |||
|
|
|||
| type ProbeResult struct { | |||
| // CheckedAt the current helath check time | |||
| CheckedAt metav1.Time | |||
There was a problem hiding this comment.
Do we need this value any more? I thought that the only that matters is LastCheckedAt in the localProbe 🤔
maksymvavilov
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Seems like it is working
The CR has no LAstCheckedAt field even when attempting to write it. No errors as well.
It might be easier to remove LastCheckedAt completely from the probe CRD and have it as a local var. Or it will make things even more complicated 🤔
In any case - it is working
|
I will merge as is and then we can enhance it more afterwards as this will stop a lot of events happening anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: craig [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED