add optional rootHost #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
reviewed
Mar 12, 2024
mikenairn
reviewed
Mar 12, 2024
mikenairn
reviewed
Mar 12, 2024
add validate call to publish remove GetRootDomain. Improve validation and tests expect wildcard endpoint
mikenairn
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow a rootHost to be set. Validate that if it is set all endpoints are either equal to or children of the root host
@mikenairn I have added a validate. Let me know if you think this is the right place to call it (publishRecord) or should it be directly in the reconcile
Validation
create dnsrecord with rootHost and endpoints using different root host. Should see message in status