Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily copy external dns plan and registry code #67

Merged

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Mar 28, 2024

closes #68

Import external dns plan package and txt registry

Moves the external-dns plan package into this repo along with the txt registry.

To ease development, code reviews, and make it easier for folks to get up to speed with plan/registry code, we will initially just work off a copy of the relevant external-dns code in this repo. When we have a solution that works for us we will look into how we can submit that back to external-dns.

Code is copied, unmodified where possible, from the v0.14.1 version of external-dns. https://github.com/kubernetes-sigs/external-dns/tree/v0.14.1

registry: Remove old txt record creation

Remove the creation of the old format txt records. It adds another extra record for every endpoint we are managing and it's unnecessary in our case since we don't have any old style records in existence that need migrated.

Update external-dns go module to v0.14.1

Changes to various go modules versions, but nothing major. Additional config required around batching requests for AWS provider, added external-dns default values for this.

Notes:

  • There are no functional changes here, code has only moved, test passing should be a good enough review.
  • All code in internal/extrnal-dns should be considered separate from the main dns-operator code and we should treat it as such. Logging and testing for example should be kept consistent with how external-dns approaches things and we should not import our own code outside of internal/external-dns into here.
  • external-dns uses a different logger from us (logrus), will look into how we can better handle that to get consistent logging in a different issue (Was already an issue, nothing new due to this change).

Move the external-dns plan package into this repo along with the txt
registry.

To ease development we will initially just work off a copy of the
relevant external-dns code in this repo. When we have a solution that
works for us we will look into how we can submit that back to
external-dns.

Code is copied, unmodified where possible, from the v0.14.1 version of
external-dns. https://github.com/kubernetes-sigs/external-dns/tree/v0.14.1
Remove the creation of the old format txt records. It adds another extra
record for every endpoint we are managing and it's unnecessary in our
case since we don't have any old style records in existence that need
migrated.
@mikenairn mikenairn force-pushed the copy_extdns_plan_and_registry_code branch from ebead89 to e3d1f69 Compare March 28, 2024 12:45
@mikenairn mikenairn added this pull request to the merge queue Apr 3, 2024
Merged via the queue into Kuadrant:main with commit bb699a6 Apr 3, 2024
9 checks passed
@mikenairn mikenairn deleted the copy_extdns_plan_and_registry_code branch April 3, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move plan and registry code to dns operator repo
2 participants