Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add health check block to DNSRecord spec #69

Merged
merged 1 commit into from
Apr 4, 2024
Merged

add health check block to DNSRecord spec #69

merged 1 commit into from
Apr 4, 2024

Conversation

philbrookes
Copy link
Collaborator

No description provided.

@philbrookes philbrookes force-pushed the gh-44-add-healthcheck-to-dnsrecord-spec branch 2 times, most recently from 961defe to 371b30d Compare April 4, 2024 08:48
mikenairn
mikenairn reviewed Apr 4, 2024
View reviewed changes
bundle.Dockerfile Outdated Show resolved Hide resolved
mikenairn
mikenairn approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. We need to look into making sure the operator sdk version being used is always the same but i guess since CI isn't complaining about it 🤷

@philbrookes philbrookes force-pushed the gh-44-add-healthcheck-to-dnsrecord-spec branch from 371b30d to 0703d8c Compare April 4, 2024 10:41
@philbrookes philbrookes added this pull request to the merge queue Apr 4, 2024
Merged via the queue into Kuadrant:main with commit 4fab316 Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenairn mikenairn mikenairn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philbrookes @mikenairn