GH-34 emmit write counter as a metric #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymvavilov
force-pushed
the
GH-34
branch
2 times, most recently
from
70a865b to
25f09fb
Compare
maleck13
reviewed
Apr 16, 2024
| @@ -336,8 +339,16 @@ func (r *DNSRecordReconciler) applyChanges(ctx context.Context, dnsRecord *v1alp | |||
| // generation has not changed but there are changes. | |||
| // implies that they were overridden - bump write counter | |||
| if !generationChanged(dnsRecord) { | |||
| dnsRecord.Status.WriteCounter++ | |||
| logger.V(3).Info("Changes needed on the same generation of record") | |||
| if dnsRecord.Status.WriteCounter < WriteCounterLimit { | |||
There was a problem hiding this comment.
do we set any dimension on this metric? Seems like we should set the the dnsRecord name and namespace as labels?
There was a problem hiding this comment.
As I read it we will increment this for all dns records so only ever 20 writes or am I mistaken
There was a problem hiding this comment.
yes, only 20 writes per generation of DNS record (frankly, if we have more than 2 writes per gen something is wrong with the DNS provider or, more accurately, something keeps overriding changes)
maleck13
requested changes
Apr 16, 2024
|
|
maleck13
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emmiting write counter as a metric and setting an upper limit for the counter after witch we give up