add kustomize as prereq for the quickstart #161
Conversation
Signed-off-by: Laura Fitzgerald <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laurafitzgerald The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for graceful-kangaroo-3c9c10 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -11,6 +11,7 @@ In this quick start, we will cover: | |||
| - [Kind](https://kind.sigs.k8s.io/) | |||
| - [Kubectl](https://kubernetes.io/docs/tasks/tools/) | |||
| - [Helm](https://helm.sh/) | |||
| - [Kustomize](https://kubectl.docs.kubernetes.io/installation/kustomize/) | |||
There was a problem hiding this comment.
I recall this wasn't a pre-req as its run inside a container?
Maybe that's no longer the case?
There was a problem hiding this comment.
It looks like in the code there was some preparation for that but it doesn't see that it's been applied to all cases where kustomize is used. I can address that instead if that's preferred.
I saw first failure at https://github.com/Kuadrant/kuadrant-operator/blob/main/hack/quickstart-setup.sh#L465
These lines would also be affected https://github.com/Kuadrant/kuadrant-operator/blob/main/hack/quickstart-setup.sh#L479-L481
There was a problem hiding this comment.
Undrestood.
Perhaps using kubectl apply -k would be sufficient for those cmds?
$subject