Move kuadrant resources to separate kustomization file #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-martin
force-pushed
the
move-kuadrant-resources
branch
from
dcf90fd to
6fbdb3e
Compare
Signed-off-by: David Martin <[email protected]>
david-martin
force-pushed
the
move-kuadrant-resources
branch
from
b84e2f0 to
09ce84c
Compare
Signed-off-by: David Martin <[email protected]>
|
pending dnsrecord crd, example resource and tests |
Signed-off-by: David Martin <[email protected]>
david-martin
force-pushed
the
move-kuadrant-resources
branch
from
09ce84c to
549c3d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits out the kuadrant specific resources (TLSPolicy, AuthPolicy etc...) into a separate kustomization file that generates a customresourcestate configmap with both the gateway api config and kuadrant resource config combined.
To do this, the base configmap is appended to with the kuadrant resources, and the resulting file is checked in.
A workflow action ensures the latest content is always generated if the base file or kaudrant specific file changes.
This change splits out & adds new test for the kuadrant DNSRecord resource (though existing kuadrant resource tests remain under the
gatewayapi_prefix for backwards compatibility for now).The existing e2e tests script behaves as before, testing all gateway api and kuadrant resources.
After a new release (latest is 0.4.0 at this time), the default behaviour when you pull in the kustomization.yaml file in the root of the repo will now only include the metrics config for gateway api resources.
To include the metrics config for both the gateway api resources and kuadrant resources, the ./config/kuadrant/kustomization.yaml file will need to be included.
(In the kaudrant-operator, this line will need to be updated https://github.com/Kuadrant/kuadrant-operator/blob/main/config/observability/kustomization.yaml#L6)
For example: