Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downstream script #133

Merged
merged 1 commit into from
Oct 25, 2024
Merged

downstream script #133

merged 1 commit into from
Oct 25, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Oct 23, 2024

  • downstream script

Based on dockerfile updates PR, will rebase when it lands.

@jasonmadigan
Copy link
Member Author

/hold

@jasonmadigan jasonmadigan changed the title downstream script downstream script + dockerfile updates Oct 23, 2024
@jasonmadigan jasonmadigan changed the title downstream script + dockerfile updates downstream script Oct 23, 2024
Signed-off-by: Jason Madigan <[email protected]>
@jasonmadigan jasonmadigan marked this pull request as ready for review October 25, 2024 09:06
@openshift-ci openshift-ci bot requested review from maleck13 and R-Lawton October 25, 2024 09:06
@R-Lawton
Copy link
Contributor

do we want the install.yaml to update to ?

@jasonmadigan
Copy link
Member Author

do we want the install.yaml to update to ?

You thinking displayName: https://github.com/Kuadrant/kuadrant-console-plugin/blob/main/install.yaml#L138C1-L139C1 ?

@R-Lawton
Copy link
Contributor

Nevermind, i got confused 😄
/lgtm

Copy link

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan, R-Lawton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [R-Lawton,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 966ea76 into main Oct 25, 2024
5 checks passed
@jasonmadigan jasonmadigan deleted the downstream-script branch October 25, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants