Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Policy form fix and load balancing fix #137

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

R-Lawton
Copy link
Contributor

@R-Lawton R-Lawton commented Oct 24, 2024

Fixed:

  • Form view they are less squshed and have even margins between the form groups etc
  • Load balancing isn't required so that's now optional
  • Made load balancing an extendable section like health check since it is optional
  • Made it so that validation checks if the extendable sections are open and if values are filled in for greying out the create button. It also allows them to stay open when going from yaml to form
  • Load balancing cant be edited so greyed that out in edit mode

Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: R-Lawton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@R-Lawton R-Lawton marked this pull request as ready for review October 24, 2024 18:26
@R-Lawton R-Lawton removed the request for review from david-martin October 24, 2024 18:26
@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c5fdb63 into main Oct 25, 2024
5 checks passed
@jasonmadigan jasonmadigan deleted the gh-128 branch November 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants