Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology: add gatewayclass filtering #139

Merged
merged 1 commit into from
Oct 30, 2024
Merged

topology: add gatewayclass filtering #139

merged 1 commit into from
Oct 30, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Oct 30, 2024 •
edited
Loading

Two changes:

  • Add a way to filter "connected" nodes from the graph (e.g. GatewayClass
  • Nudge the Kuadrant resource into the Kuadrant internals node group

Before:
Screenshot 2024-10-30 at 15 11 21

After:

Screenshot 2024-10-30 at 15 10 37

@jasonmadigan
Copy link
Member Author

@R-Lawton ^

@jasonmadigan jasonmadigan added enhancement New feature or request policy-topology labels Oct 30, 2024
@R-Lawton
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan, R-Lawton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [R-Lawton,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 206ddfe into main Oct 30, 2024
6 checks passed
@jasonmadigan jasonmadigan deleted the filter-gatewayclasses branch November 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Lawton R-Lawton R-Lawton approved these changes

@david-martin david-martin Awaiting requested review from david-martin

Assignees

@R-Lawton R-Lawton

Labels
approved enhancement New feature or request lgtm policy-topology
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonmadigan @R-Lawton