Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource filtering #167

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Resource filtering #167

merged 2 commits into from
Nov 19, 2024

Conversation

R-Lawton
Copy link
Contributor

@R-Lawton R-Lawton commented Nov 18, 2024

Filtering across name , ns and type
Screenshot 2024-11-19 at 17 09 12

Signed-off-by: Jason Madigan <[email protected]>
Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: R-Lawton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@R-Lawton R-Lawton force-pushed the resource-filtering branch 2 times, most recently from 88ba24d to 7e9e2a9 Compare November 18, 2024 17:11
@R-Lawton R-Lawton removed the request for review from maleck13 November 18, 2024 17:12
@R-Lawton
Copy link
Contributor Author

CC: @jasonmadigan

@R-Lawton
Copy link
Contributor Author

/hold

@R-Lawton R-Lawton force-pushed the resource-filtering branch 2 times, most recently from b486f2e to ea99513 Compare November 18, 2024 17:56
@R-Lawton
Copy link
Contributor Author

/unhold

locales/en/plugin__kuadrant-console-plugin.json Outdated Show resolved Hide resolved
src/components/ResourceList.tsx Outdated Show resolved Hide resolved
@R-Lawton
Copy link
Contributor Author

fixed a issue with dark mode where a diff shade of gray was showing when there wasn't as many resources showing in the table
Screenshot 2024-11-19 at 17 10 22

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 59839c4 into main Nov 19, 2024
5 checks passed
@jasonmadigan jasonmadigan deleted the resource-filtering branch November 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants