generated from openshift/console-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Modal #45
Merged
Merged
Delete Modal #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Madigan <[email protected]>
Closed
jasonmadigan
commented
Sep 5, 2024
Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
delete-action
branch
from
September 5, 2024 16:25
f1b0190
to
5e1a5c9
Compare
@david-martin good spot, done. Added some i18n strings too. |
david-martin
reviewed
Sep 6, 2024
const onSelect = (_event: React.MouseEvent<Element, MouseEvent> | undefined, value: string | number | undefined) => { | ||
// eslint-disable-next-line no-console | ||
console.log('selected', value); | ||
const getModelFromResource = (obj: K8sResourceCommon): K8sModel => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll likely move this out for reuse after merge.
david-martin
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #16
@patternfly/react-core/next
for a new ModalAllPoliciesListPage
- combined theuseK8sWatchResource
hooks into a single array mapping for sanityTesting:
Create a test resource, for example a TLSPolicy: