Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnspolicy create #47

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Dnspolicy create #47

merged 1 commit into from
Sep 11, 2024

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Sep 6, 2024

Part of #30 (the create part)

There's a lot in the create page because of the optional top level fields for healthCheck and loadBalancing (which is based on setting routingStrategy to loadbalanced).
The other top level fields are less complex:

  • name
  • namespace (uses a namespace dropdown)
  • targetRef (uses a gateway dropdown by listing all gateways in the cluster)

TODO:

Screenshots

Initial Create page

image

Expanded page

image

Yaml editor

image

@david-martin david-martin force-pushed the dnspolicy-create branch 2 times, most recently from a3626c8 to fbfde44 Compare September 11, 2024 13:49
@david-martin david-martin marked this pull request as ready for review September 11, 2024 13:54

React.useEffect(() => {
const updatedYamlResource = {
apiVersion: 'kuadrant.io/v1alpha1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing, but I guess this applies to all of these views - should we have a helper to fetch the latest apiVersions for our resources? saves us having to deal with drift here (well, for the most part). I guess ditching the apiVersion would do the same.

src/components/KuadrantPoliciesPage.tsx Show resolved Hide resolved
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fd592ed into main Sep 11, 2024
3 checks passed
@jasonmadigan jasonmadigan deleted the dnspolicy-create branch October 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants