-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnspolicy create #47
Dnspolicy create #47
Conversation
a3626c8
to
fbfde44
Compare
Signed-off-by: David Martin <[email protected]>
fbfde44
to
1e5b487
Compare
|
||
React.useEffect(() => { | ||
const updatedYamlResource = { | ||
apiVersion: 'kuadrant.io/v1alpha1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small thing, but I guess this applies to all of these views - should we have a helper to fetch the latest apiVersions for our resources? saves us having to deal with drift here (well, for the most part). I guess ditching the apiVersion would do the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin, jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Part of #30 (the create part)
There's a lot in the create page because of the optional top level fields for healthCheck and loadBalancing (which is based on setting routingStrategy to loadbalanced).
The other top level fields are less complex:
TODO:
weighted.custom[].selector
Screenshots
Initial Create page
Expanded page
Yaml editor