-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RateLimitPolicy create page #63
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
934c69c
to
e5ea21d
Compare
e5ea21d
to
41801ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small things, but other than that, looks good.
Signed-off-by: David Martin <[email protected]>
41801ba
to
df1b5a0
Compare
@jasonmadigan thanks for reviewing. |
Changes look good, let me give it a quick spin again |
I'd say that's the same for all Edit buttons? |
Must've had a fever dream where I thought some of these worked - nevermind so! /lgtm |
Closes #31
Screenshots below.
A few fields have been purposefully left out of the form view as the API will be changing for kuadrant v1.
Future changes to the from are captured in #68
In the interim, an info message is shown to direct the user to the yaml view for more complex limits configuration beyond simple limits.
Create form
Add Limit modal
### Limits in form
### Yaml editor