Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RateLimitPolicy create page #63

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add RateLimitPolicy create page #63

merged 1 commit into from
Sep 13, 2024

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Sep 11, 2024

Closes #31

Screenshots below.
A few fields have been purposefully left out of the form view as the API will be changing for kuadrant v1.
Future changes to the from are captured in #68
In the interim, an info message is shown to direct the user to the yaml view for more complex limits configuration beyond simple limits.

Create form

image

Add Limit modal

image

### Limits in form

image

### Yaml editor

image

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things, but other than that, looks good.

src/components/KuadrantRateLimitPolicyCreatePage.tsx Outdated Show resolved Hide resolved
src/components/KuadrantRateLimitPolicyCreatePage.tsx Outdated Show resolved Hide resolved
@david-martin
Copy link
Member Author

@jasonmadigan thanks for reviewing.
I've pushed up recommended changes.
Also added i18n strings.

@jasonmadigan
Copy link
Member

Changes look good, let me give it a quick spin again

@jasonmadigan
Copy link
Member

Works good, noticed one small thing - the edit action in the RLP list view doesn't seem to navigate to edit

Screenshot 2024-09-13 at 16 06 52

@david-martin
Copy link
Member Author

the edit action in the RLP list view doesn't seem to navigate to edit

I'd say that's the same for all Edit buttons?
There's a separate issue to figure out reusing the create view as an edit view #59

@jasonmadigan
Copy link
Member

Must've had a fever dream where I thought some of these worked - nevermind so!

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1523aa9 into main Sep 13, 2024
3 checks passed
@jasonmadigan jasonmadigan deleted the rlp-create branch September 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rate limit policy create/update
3 participants