Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard view #69

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Dashboard view #69

merged 1 commit into from
Sep 18, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Sep 13, 2024 •
edited
Loading

Draft PR, implements #33

Add's Kuadrant dashboard view.

TODID:

  • Gateways list
  • API / HTTPRoute list
  • Alerts list?
  • i18n

Screenshot:
Screenshot 2024-09-17 at 16 56 50

TODO later:

  • Final links (this will have to wait have to wait), will create a follow-up issue
  • Tweaks to status/ conditions in lists (will come later)

Out of scope for now: Alerts

@jasonmadigan jasonmadigan force-pushed the dashboard-view branch 3 times, most recently from 35e0f2f to d5b1483 Compare September 13, 2024 14:58
@jasonmadigan jasonmadigan linked an issue Sep 13, 2024 that may be closed by this pull request
Create the Overview / Dashboard view #33
Closed
@jasonmadigan jasonmadigan force-pushed the dashboard-view branch 5 times, most recently from 200e432 to c4b2416 Compare September 17, 2024 15:58
@jasonmadigan jasonmadigan marked this pull request as ready for review September 17, 2024 15:58
@openshift-ci openshift-ci bot requested review from maleck13 and R-Lawton September 17, 2024 15:58
jasonmadigan
jasonmadigan commented Sep 18, 2024
View reviewed changes
src/constants/links.ts Outdated Show resolved Hide resolved
src/constants/links.ts Show resolved Hide resolved
@jasonmadigan jasonmadigan force-pushed the dashboard-view branch 2 times, most recently from 9a0603f to 9897c05 Compare September 18, 2024 10:17
@david-martin
Copy link
Member

👀

@jasonmadigan
Copy link
Member Author

Made a slight tweak just now to make the getting started resources section:

  • collapsible the arrow
  • hideable for a session via an action

@jasonmadigan
Overview view
456a02e 
Signed-off-by: Jason Madigan <[email protected]>
david-martin
david-martin approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 42cc9e2 into main Sep 18, 2024
3 checks passed
@jasonmadigan jasonmadigan deleted the dashboard-view branch October 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-martin david-martin david-martin approved these changes

@maleck13 maleck13 Awaiting requested review from maleck13

@R-Lawton R-Lawton Awaiting requested review from R-Lawton

Assignees

@david-martin david-martin

Labels
approved lgtm
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the Overview / Dashboard view
3 participants
@jasonmadigan @david-martin @openshift-merge-robot