This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
add back envoyfilter to add limitador cluster patch #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
reviewed
Jun 7, 2022
| for _, stage := range RateLimitStages { | ||
| wasmKey := kuadrantistioutils.WASMPluginKey(gwKey, stage) | ||
|
|
||
| wasmplugin := &istioextensionv1alpha3.WasmPlugin{} |
There was a problem hiding this comment.
The name was wrong. we are importing alpha1 but named it alpha3.
There was a problem hiding this comment.
then the name should be fixed. You were planning to do that in another PR?
There was a problem hiding this comment.
By name here, I mean the name of the import i.e. istioextensionv1alpha1. It's already in this PR.
eguzki
reviewed
Jun 7, 2022
| if wasmPluginDeleted { | ||
| ef := &istionetworkingv1alpha3.EnvoyFilter{} | ||
| efKey := client.ObjectKey{Namespace: gwKey.Namespace, Name: kuadrantistioutils.LimitadorClusterEnvoyFilterName} | ||
| err := r.Client().Get(ctx, efKey, ef) |
There was a problem hiding this comment.
why not delete and skip isNotFound errors?
There was a problem hiding this comment.
Good find :)
eguzki
reviewed
Jun 7, 2022
rahulanand16nov
force-pushed
the
add-back-envoy-filter
branch
from
1243913 to
0260e9d
Compare
eguzki
approved these changes
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#152 Had removed the
EnvoyFilterresource but due to the reason mentioned on that PR, we need to add it back so that it continues to work when installed using the operator.PR changes can be verified by trying any one of the user guides.