Fix Integration Test

Kuadrant · Jan 18, 2024 · 885eb2d · 885eb2d
1 parent 53a709c
commit 885eb2d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/controllers/gateway_kuadrant_controller_test.go b/controllers/gateway_kuadrant_controller_test.go
@@ -69,19 +69,21 @@ var _ = Describe("Kuadrant Gateway controller", func() {
 	})
 
 	Context("Two kuadrant instances", func() {
+		var secondNamespace string
 
 		BeforeEach(func() {
+			CreateNamespace(&secondNamespace)
 			newKuadrantName := "second"
 			newKuadrant := &kuadrantv1beta1.Kuadrant{
 				TypeMeta:   metav1.TypeMeta{APIVersion: "v1beta1", Kind: "Kuadrant"},
-				ObjectMeta: metav1.ObjectMeta{Name: newKuadrantName, Namespace: testNamespace},
+				ObjectMeta: metav1.ObjectMeta{Name: newKuadrantName, Namespace: secondNamespace},
 			}
 			err := testClient().Create(context.Background(), newKuadrant)
 			Expect(err).ToNot(HaveOccurred())
 
 			Eventually(func() bool {
 				kuadrant := &kuadrantv1beta1.Kuadrant{}
-				err := k8sClient.Get(context.Background(), client.ObjectKey{Name: newKuadrantName, Namespace: testNamespace}, kuadrant)
+				err := k8sClient.Get(context.Background(), client.ObjectKey{Name: newKuadrantName, Namespace: secondNamespace}, kuadrant)
 				if err != nil {
 					return false
 				}
@@ -92,6 +94,8 @@ var _ = Describe("Kuadrant Gateway controller", func() {
 			}, time.Minute, 5*time.Second).Should(BeTrue())
 		})
 
+		AfterEach(DeleteNamespaceCallback(&secondNamespace))
+
 		It("new gateway should not be annotated", func() {
 			gateway := testBuildBasicGateway(gwName, testNamespace)
 			err := k8sClient.Create(context.Background(), gateway)

diff --git a/controllers/helper_test.go b/controllers/helper_test.go
@@ -62,10 +62,7 @@ func CreateNamespace(namespace *string) {
 	existingNamespace := &v1.Namespace{}
 	Eventually(func() bool {
 		err := testClient().Get(context.Background(), types.NamespacedName{Name: generatedTestNamespace}, existingNamespace)
-		if err != nil {
-			return false
-		}
-		return true
+		return err == nil
 	}, time.Minute, 5*time.Second).Should(BeTrue())
 
 	*namespace = existingNamespace.Name