-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test OLM upgrade path #1165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 83.30% 83.42% +0.11%
==========================================
Files 81 81
Lines 6943 6943
==========================================
+ Hits 5784 5792 +8
+ Misses 933 925 -8
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bd7877c
to
fbc828b
Compare
fbc828b
to
943156a
Compare
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
943156a
to
b06d471
Compare
I tried running the verification steps and it failed. |
You tried to upgrade kuadrant from 1.0.1 to 0.0.0. Not surprised it failed. Did you prepare a new release? |
I copied and pasted the instructions in the verification steps. |
Your workspace in the pushed commit does not have the
Might be you did not add all the changes to the commit. Could it be? |
I This worked great for me using the verification steps. I did have to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Implements #1117 and is part of the work being done for #1112
It's a Github Action Workflow to test the Kuadrant upgrade process using OLM APIs.
It is being triggered manually (
on.workflow_dispatch
) and accepts as input:kuadrantStartVersion
: Kuadrant start version (required). For example:1.0.0
(withoutv
prefix)kuadrantNamespace
: Namespace where Kuadrant is installed (optional defaults tokuadrant-system
).clusterServer
: Cluster server URL (optional defaults to local kind cluster). For example:https://example.com:443
clusterToken
: Cluster Server Bearer Token (optional defaults to local kind cluster token). For example:sha256~abcdefghijk12345432432
The workflow goes as follows:
kuadrantStartVersion
. It's being installed traditionally using OLM: OperatorGroup + CatalogSource (with the catalog build for thekuadrantStartVersion
) + Subscription.Simple commands are being coded as part of the Github workflow. For high level commands, those are implemented using makefile targets or third party tools so they can be easily run locally to dev/test.
Verification Steps
Prepare a new release, let's say v1.0.2
Commit and push the branch (
testing-upgrade
in the example).Then, run workflow manually (cannot be done from github UI as it has not been merged to
main
branch). This run would test upgrade fromv1.0.1
tov1.0.2
:Check the upgrade test workflow run to complete successfully.