[authpolicy-v2] AuthConfig superseding of strict host subsets #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## authpolicy-v2 #266 +/- ##
=================================================
+ Coverage 63.12% 63.26% +0.13%
=================================================
Files 34 34
Lines 3241 3242 +1
=================================================
+ Hits 2046 2051 +5
+ Misses 1025 1023 -2
+ Partials 170 168 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Enables [superseding of strict host subsets](https://github.com/Kuadrant/authorino/blob/main/docs/architecture.md#avoiding-host-name-collision) in Authorino – i.e., set `SupersedingHostSubsets` to `true` in the Authorino CR. Closes #264.
guicassolato
force-pushed
the
authpolicy-v2
branch
from
4820025 to
8818edb
Compare
guicassolato
force-pushed
the
supersede-authconfig-subsets
branch
from
e3deea4 to
02459af
Compare
|
+1 |
didierofrivia
approved these changes
Oct 11, 2023
9 tasks
guicassolato
added a commit
that referenced
this pull request
Oct 11, 2023
[authpolicy-v2] AuthConfig superseding of strict host subsets
guicassolato
added a commit
that referenced
this pull request
Oct 16, 2023
[authpolicy-v2] AuthConfig superseding of strict host subsets
guicassolato
added a commit
that referenced
this pull request
Oct 18, 2023
[authpolicy-v2] AuthConfig superseding of strict host subsets
guicassolato
added a commit
that referenced
this pull request
Oct 20, 2023
[authpolicy-v2] AuthConfig superseding of strict host subsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
SupersedingHostSubsetstotruein the Authorino CR to enable superseding of strict host subsets in AuthorinoNote: Technically, these 2 changes could be targeting
maininstead of base branchauthpolicy-v2, but because Authorino Operator v0.9.0 includes all the gears to support AuthConfig v1beta2 (i.e. enables installations of Authorino v0.15.0), there's no point in merging it outside of the context of AuthPolicy v2.