set the policy controller to the latest release branch #314
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 64.42% 64.47% +0.05%
==========================================
Files 35 35
Lines 3806 3806
==========================================
+ Hits 2452 2454 +2
+ Misses 1158 1157 -1
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -1,5 +1,5 @@ | |||
| resources: | |||
| - github.com/Kuadrant/multicluster-gateway-controller/config/policy-controller/default?ref=main | |||
| - github.com/Kuadrant/multicluster-gateway-controller/config/policy-controller/default?ref=release-0.2 | |||
There was a problem hiding this comment.
I'd say that these kind of version pointing in our manifests in main branch, should point to floating latest tag or main branch, and use the specific version for release branches. Does it make sense?
There was a problem hiding this comment.
on a second thought, if we want to treat the policy controller as an external dependency, say, like istio, it's a different story
There was a problem hiding this comment.
issue with that is, any time something changes in the policy controller repo yamls, it will mean the verify-bundle will fail in this repo
There was a problem hiding this comment.
Authorino is listed as a dependency and it points it to main:
There was a problem hiding this comment.
In fact, I think the policy controller could be treated the same way. Why not having it under config/dependencies?
There was a problem hiding this comment.
This really depends what you are trying to achieve. If you want the TLSPolicy and DNSPolicy CRDs and policy controller deployment included in the kuadrant-operator bundle, then adding them to config/dependencies probably won't work. AFAIK, none of those dependencies are pulled into the bundle and the likes of kuadrant-operator/config/dependencies/authorino/kustomization.yaml is only used where you want to run everything without OLM. In a normal OLM installation authorinio-operator is installed as an OLM dependency since it has it's own bundle, policy-controller doesn't.
There was a problem hiding this comment.
Makes sense. Indeed the APIs defined by those dependencies are not part of Kuadrant Operator's bundle.
There was a problem hiding this comment.
Ok so only question is whether it should ref main or not. I am thinking not at least initially
There was a problem hiding this comment.
About fixing a version or using latest, I think the logic behind it was that:
- components we control we default to latest – and therefore we pick up changes in those that affect Kuadrant Operator as soon as possible, whereas
- components we do not control we fix a version – and therefore ensure stability of Kuadrant Operator before externalities going on on those projects.
There was a problem hiding this comment.
Ok so then we don't change this one and we close this PR?
|
Closing then? |
moves the kustomize to ref the release branch instead of main