-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 361 single cluster walk through #362
Gh 361 single cluster walk through #362
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 66.14% 65.31% -0.84%
==========================================
Files 35 35
Lines 3843 3843
==========================================
- Hits 2542 2510 -32
- Misses 1113 1136 +23
- Partials 188 197 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@maleck13 The Istio CRD is missing. I get this error when applying the example resource in the PR instructions:
Other istio CRDs are there
|
Yes sorry you need to check out this branch #323 |
I'll check out that branch, and follow steps from this PR branch. |
@david-martin I've just merged the branch to main so you could try from main |
dcacb19
to
4804b5e
Compare
curl -k --resolve "api.${KUADRANT_ZONE_ROOT_DOMAIN}:443:172.18.200.2" "https://api.${KUADRANT_ZONE_ROOT_DOMAIN}/cars" -vvv 200 OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues with curl on macos, but a workaround with --resolve
works well.
Output at end of walkthrough:
while :; do curl -k --write-out '%{http_code}\n' --silent --output /dev/null -H 'Authorization: APIKEY IAMALICE' "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" | grep -E --color "\b(429)\b|$"; sleep 1; done
200
429
429
200
429
429
200
429
429
200
^C
$ while :; do curl -k --write-out '%{http_code}\n' --silent --output /dev/null -H 'Authorization: APIKEY IAMBOB' "https://api.$KUADRANT_ZONE_ROOT_DOMAIN/cars" | grep -E --color "\b(429)\b|$"; sleep 1; done
200
429
429
200
429
429
200
got to the same stage as @david-martin, so I think this looks like it works all-in (probably want to update the cURL commands to use --resolve) |
cba3d16
to
05d5f0a
Compare
05d5f0a
to
817c3c5
Compare
@jasonmadigan @david-martin I have updated the curl commands now |
@maleck13 couple of tweaks w/ suggestions |
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
Co-authored-by: Jason Madigan <[email protected]>
thanks @jasonmadigan updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a few comments despite already merged.
@guicassolato #374 follow ups |
closes #361
depends on #323
related to Kuadrant/docs.kuadrant.io#44
Verification
Note it is expected that you will need to setup a managed zone and provider secret currently. The quickstart script will do this but to verify this, do that step yourself
We don't have the quick start script yet so to get an environment ready in the same way do the following: