Use tag for project sail, not branch #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper tag of project sail: sail-mvp2
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 65.03% 64.74% -0.29%
==========================================
Files 35 35
Lines 3795 3795
==========================================
- Hits 2468 2457 -11
- Misses 1134 1141 +7
- Partials 193 197 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -1,4 +1,4 @@ | |||
| --- | |||
| namespace: istio-system | |||
| resources: | |||
| - github.com/maistra/istio-operator/config/default?ref=maistra-3.0 | |||
| - github.com/maistra/istio-operator/config/default?ref=sail-mvp2 | |||
There was a problem hiding this comment.
I had a look at using this tag before - unfortunately the code is pinned but the deployment uses the floating 3.0-latest tag which is not compatible with the tagged code. We could potentially patch the deployment with a compatible nightly build. This will hopefully be fixed in the future so we don't have to override the deployment image ourselves - #382 (comment)
|
Superseded by #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper tag of project sail: sail-mvp2