Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add high level metrics explanation docs page #504

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add high level metrics explanation docs page #504

merged 1 commit into from
Apr 22, 2024

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Mar 21, 2024 •
edited
Loading

@david-martin david-martin mentioned this pull request Mar 22, 2024
Merged
@david-martin david-martin marked this pull request as ready for review April 19, 2024 13:28
@david-martin david-martin requested a review from a team as a code owner April 19, 2024 13:28
@david-martin
Copy link
Member Author

Updated to include metrics and telemetry config for latest dashboards.
Moved from draft.

@jasonmadigan
Copy link
Member

👀

jasonmadigan
jasonmadigan approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small tweaks as suggestions, but otherwise looks good

doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
doc/observability/metrics.md Outdated Show resolved Hide resolved
jasonmadigan
jasonmadigan approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small tweaks as suggestions, but otherwise looks good

@david-martin
Copy link
Member Author

Thanks @jasonmadigan
Suggested accepted & squashed.

@jasonmadigan
Copy link
Member

Looks good, merge when built

@jasonmadigan jasonmadigan merged commit b5e6bf1 into Kuadrant:main Apr 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmadigan jasonmadigan jasonmadigan approved these changes

@R-Lawton R-Lawton Awaiting requested review from R-Lawton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document descriptions of the metrics uses in the alerts and dashboard templates
2 participants
@david-martin @jasonmadigan