-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exported dashboards for sharing, created dashboard export script, upload dashboard github action and updated documentation #641
exported dashboards for sharing, created dashboard export script, upload dashboard github action and updated documentation #641
Conversation
I will take a look and get back to you - good catch ! |
@david-martin it seems to be an issue with the data source within the JSON according to this forum thread. I'll see if I can find anything within the JSON that can be removed that will allow the dashboard template be uploaded to Grafana, but also allow the user uploading within their Grafana instance to select their own data source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this could be our problem. Let me see if I can change this back to datasource.
@david-martin made changes and tested to see if upload is okay on both Grafana instance and on Grafana Community Dashboards. |
Feedback to implement from @david-martin :
|
Not really - still doesn't export as needed. |
@david-martin hope the changes suit :) |
133ae36
to
3719175
Compare
3719175
to
cd20313
Compare
@david-martin Feel free to review - changes are ready for review :) |
@david-martin I have added git diff within the action to check the changed files. Let me know if there's anything else I need to address. :) |
/lgtm Thanks for taking the time to make these improvements @ehearneRedHat |
Thank you @david-martin for making the suggestions so I can improve my
work. :)
…On Thu, May 16, 2024 at 1:12 PM David Martin ***@***.***> wrote:
/lgtm
/approve
Thanks for taking the time to make these improvements @ehearneRedHat
<https://github.com/ehearneRedHat>
—
Reply to this email directly, view it on GitHub
<#641 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFHWGVLHVXGKQYUDGXJZ6YDZCSPEFAVCNFSM6AAAAABHT44XXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGA4DOMBVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Evan Hearne
Software Engineer Intern
Red Hat <https://www.redhat.com>
<https://www.redhat.com>
|
* KuadrantGH-641 enforced condition on dnspolicy * KuadrantGH-641 updating integration tests * KuadrantGH-454 afregate statuses of the DNS records
What (currently completed):
Verify (currently completed):
admin/admin
and export the following dashboards, ensuring the toggle "Export for sharing manually" is toggled:config/observability/README.md
for running the script to create a universal dashboard. Test by importing into local Grafana instance, and uploading to Grafana Community Platform.