Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sotw: auth #952

Merged
merged 25 commits into from
Nov 5, 2024

docs: updated user guide Enforcing authentication & authorization wit…

6138e34
Select commit
Loading
Failed to load commit list.
Merged

sotw: auth #952

docs: updated user guide Enforcing authentication & authorization wit…
6138e34
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 5, 2024 in 1s

76.55% (-4.94%) compared to 63f1d28

View this Pull Request on Codecov

76.55% (-4.94%) compared to 63f1d28

Details

Codecov Report

Attention: Patch coverage is 86.25162% with 212 lines in your changes missing coverage. Please review.

Project coverage is 76.55%. Comparing base (63f1d28) to head (6138e34).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta3/authpolicy_types.go 85.28% 38 Missing and 1 partial ⚠️
...ntrollers/envoy_gateway_auth_cluster_reconciler.go 80.13% 25 Missing and 4 partials ⚠️
controllers/istio_auth_cluster_reconciler.go 80.82% 24 Missing and 4 partials ⚠️
pkg/istio/utils.go 51.78% 18 Missing and 9 partials ⚠️
controllers/authconfigs_reconciler.go 86.59% 19 Missing and 7 partials ⚠️
controllers/auth_policy_status_updater.go 91.32% 12 Missing and 5 partials ⚠️
api/v1/merge_strategies.go 60.71% 11 Missing ⚠️
controllers/auth_workflow_helpers.go 91.66% 6 Missing and 3 partials ⚠️
pkg/envoygateway/utils.go 78.04% 6 Missing and 3 partials ⚠️
controllers/effective_auth_policies_reconciler.go 88.23% 5 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   81.49%   76.55%   -4.94%     
==========================================
  Files         102      113      +11     
  Lines        7177     9056    +1879     
==========================================
+ Hits         5849     6933    +1084     
- Misses        898     1813     +915     
+ Partials      430      310     -120     
Components Coverage Δ
api/v1beta1 (u) 92.18% <100.00%> (+1.27%) ⬆️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) 87.67% <ø> (-0.47%) ⬇️
pkg/istio (u) 47.03% <ø> (-24.49%) ⬇️
pkg/log (u) 93.18% <ø> (-1.56%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 83.48% <85.01%> (+0.42%) ⬆️
Files with missing lines Coverage Δ
api/v1beta1/topology.go 100.00% <100.00%> (ø)
api/v1beta3/ratelimitpolicy_types.go 89.62% <100.00%> (+15.93%) ⬆️
controllers/auth_policies_validator.go 100.00% <100.00%> (ø)
controllers/data_plane_policies_workflow.go 100.00% <100.00%> (ø)
...rollers/effective_ratelimit_policies_reconciler.go 88.23% <100.00%> (ø)
...lers/envoy_gateway_ratelimit_cluster_reconciler.go 80.00% <100.00%> (ø)
controllers/ratelimit_policies_validator.go 100.00% <100.00%> (ø)
controllers/ratelimit_policy_status_updater.go 88.81% <100.00%> (ø)
controllers/state_of_the_world.go 92.16% <100.00%> (-5.07%) ⬇️
controllers/test_common.go 100.00% <ø> (ø)
... and 22 more

... and 48 files with indirect coverage changes