-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DNS and TLS Policies to v1 #973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
- Coverage 81.49% 76.15% -5.35%
==========================================
Files 102 111 +9
Lines 7177 8986 +1809
==========================================
+ Hits 5849 6843 +994
- Misses 898 1852 +954
+ Partials 430 291 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -32,6 +32,7 @@ const ( | |||
PolicyRuleMergeStrategy = "merge" | |||
) | |||
|
|||
// +kubebuilder:object:generate=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guicassolato Had to exclude this due to this error in generate:
merge_strategies.go:36:2: invalid field type: any
Error: not all generators ran successfully
I don't think it needs to be included anyway, let me know if you think otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me
6847045
to
6fcae1b
Compare
remove v1/topology.go for consistency with other apis Signed-off-by: Michael Nairn <[email protected]>
From what i can tell the code coverage report is broken because we have been squashing commits onto main, creating a new commit that has never had a report done on it, and codecov is using the last common commit it knows about when generating its PR reports, which is currently this one from this PR. This PR looks to have decreased it enough to the point of it failing all the PR builds. Going to merge this, creating a merge commit, so any new branches should report from this commit on. Might be an idea to disable the squash option. |
closes #762 #759