Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DNS and TLS Policies to v1 #973

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Move DNS and TLS Policies to v1 #973

merged 1 commit into from
Nov 5, 2024

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Nov 4, 2024

closes #762 #759

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 88.34951% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (63f1d28) to head (cc1b41f).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
api/v1/dnspolicy_types.go 60.00% 6 Missing ⚠️
api/v1/tlspolicy_types.go 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   81.49%   76.15%   -5.35%     
==========================================
  Files         102      111       +9     
  Lines        7177     8986    +1809     
==========================================
+ Hits         5849     6843     +994     
- Misses        898     1852     +954     
+ Partials      430      291     -139     
Flag Coverage Δ
bare-k8s-integration 10.87% <24.27%> (+1.98%) ⬆️
controllers-integration 58.86% <88.34%> (-6.47%) ⬇️
envoygateway-integration 32.50% <32.03%> (-17.80%) ⬇️
gatewayapi-integration 13.43% <24.27%> (-0.98%) ⬇️
istio-integration 34.33% <32.03%> (-19.19%) ⬇️
unit 25.36% <23.52%> (-2.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 92.18% <100.00%> (+1.27%) ⬆️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) 87.67% <ø> (-0.47%) ⬇️
pkg/istio (u) 47.03% <ø> (-24.49%) ⬇️
pkg/log (u) 93.18% <ø> (-1.56%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 84.42% <86.40%> (+1.36%) ⬆️
Files with missing lines Coverage Δ
api/v1/merge_strategies.go 47.32% <ø> (ø)
controllers/common.go 95.12% <100.00%> (ø)
controllers/dns_workflow.go 91.78% <100.00%> (-8.22%) ⬇️
controllers/dnspolicies_validator.go 100.00% <100.00%> (ø)
controllers/dnspolicy_dnsrecords.go 83.33% <100.00%> (+18.48%) ⬆️
controllers/dnspolicy_metrics.go 47.05% <100.00%> (ø)
controllers/dnspolicy_status_updater.go 90.16% <100.00%> (ø)
controllers/effective_dnspolicies_reconciler.go 78.89% <100.00%> (ø)
controllers/effective_tls_policies_reconciler.go 86.20% <100.00%> (ø)
...llers/gateway_policy_discoverability_reconciler.go 93.57% <100.00%> (-6.43%) ⬇️
... and 8 more

... and 53 files with indirect coverage changes

@@ -32,6 +32,7 @@ const (
PolicyRuleMergeStrategy = "merge"
)

// +kubebuilder:object:generate=false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guicassolato Had to exclude this due to this error in generate:

merge_strategies.go:36:2: invalid field type: any
Error: not all generators ran successfully

I don't think it needs to be included anyway, let me know if you think otherwise.

@mikenairn mikenairn marked this pull request as ready for review November 4, 2024 12:30
Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

@mikenairn mikenairn force-pushed the dns_tls_v1 branch 3 times, most recently from 6847045 to 6fcae1b Compare November 5, 2024 11:24
remove v1/topology.go for consistency with other apis

Signed-off-by: Michael Nairn <[email protected]>
@mikenairn
Copy link
Member Author

From what i can tell the code coverage report is broken because we have been squashing commits onto main, creating a new commit that has never had a report done on it, and codecov is using the last common commit it knows about when generating its PR reports, which is currently this one from this PR.

This PR looks to have decreased it enough to the point of it failing all the PR builds.

Going to merge this, creating a merge commit, so any new branches should report from this commit on. Might be an idea to disable the squash option.

@mikenairn mikenairn merged commit 0d304ad into main Nov 5, 2024
33 of 34 checks passed
@mikenairn mikenairn deleted the dns_tls_v1 branch November 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move to v1 of TLSPolicy
3 participants