Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image links to original image #69

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Nov 8, 2024

The images in the blog post #67 are difficult to read the legend on.
This change makes the images links to the original (larger in this case) image size.

I've also renamed the file for that blog post to match the directory name (and included info in the README about this) so that the path doesn't include extra nesting.

@openshift-ci openshift-ci bot requested review from alexsnaps and roivaz November 8, 2024 17:14
@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
@david-martin david-martin changed the base branch from BLOG/understanding_Cyclomatic_Complexity to main November 8, 2024 17:15
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit deb39c4
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/673215cff520a200082f2611
😎 Deploy Preview https://deploy-preview-69--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin david-martin force-pushed the add-image-links branch 2 times, most recently from c610bce to 871b49e Compare November 11, 2024 10:41
@jasonmadigan
Copy link
Member

jasonmadigan commented Nov 11, 2024

@david-martin looking at the preview, we seem to have two links to that post now:

https://deploy-preview-69--relaxed-faloodeh-7fa6f1.netlify.app/blog/
Screenshot 2024-11-11 at 12 48 22

Old doc still there? Looks like it's seen as a new file rather than rename

Signed-off-by: David Martin <[email protected]>
@david-martin
Copy link
Member Author

looking at the preview, we seem to have two links to that post now:

@jasonmadigan Fixed. The file rename actually added a 2nd file.
I've stepped through the rename in 2 commits and seems to be working now.

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8af6589 into main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants