Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APICurio guide for modifying and visualising kuadrant extensions #57

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

david-martin
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.38%. Comparing base (888948e) to head (6b59c0b).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #57   +/-   ##
=====================================
  Coverage   0.38%   0.38%           
=====================================
  Files         17      17           
  Lines        783     783           
=====================================
  Hits           3       3           
  Misses       780     780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/openapi-apicurio.md Outdated Show resolved Hide resolved
doc/openapi-apicurio.md Outdated Show resolved Hide resolved
doc/openapi-apicurio.md Outdated Show resolved Hide resolved
doc/openapi-apicurio.md Outdated Show resolved Hide resolved
@jasonmadigan
Copy link
Member

taking shape, couple of comments added

@david-martin david-martin marked this pull request as ready for review March 6, 2024 13:02
@jasonmadigan
Copy link
Member

jasonmadigan commented Mar 7, 2024

@david-martin this LGTM. It may be worth an eye from someone from Apicurio as well, but this can be merged as a draft

@david-martin
Copy link
Member Author

may be worth an eye from someone from Apicurio

@jasonmadigan Good suggestion.
Do you mind if you add lgtm etc.. and I can get a deploy preview link on the docs repo to share with them for review before it actually gets published?

@jasonmadigan
Copy link
Member

/lgtm
/approve

@david-martin
Copy link
Member Author

Merging manually.
Auto merge not marking the GH review as good, but lgtm added

@david-martin david-martin merged commit cbbd4a1 into Kuadrant:main Mar 7, 2024
5 checks passed
@david-martin david-martin deleted the apicurio-tutorial branch March 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: Apicurio, OAS Specs, x-kuadrant extensions
3 participants