Add support for name in limit definitions #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for the optional
name
field in aLimit
definition in limitador.You can deploy this locally and apply config/samples/limitador_v1alpha1_limitador.yaml to your cluster, then inspect the resulting
ConfigMap
which should now include thatname
field with the valuetoy_get_route
.This has no value per se to the system as a whole. But paired with the next PR #113 , it will give better metrics to users. The idea is to have the kuadrant operator populate this with the RLP's name.