Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for name in limit definitions #112

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add support for name in limit definitions #112

merged 2 commits into from
Nov 13, 2023

Conversation

alexsnaps
Copy link
Member

@alexsnaps alexsnaps commented Nov 7, 2023

This add support for the optional name field in a Limit definition in limitador.
You can deploy this locally and apply config/samples/limitador_v1alpha1_limitador.yaml to your cluster, then inspect the resulting ConfigMap which should now include that name field with the value toy_get_route.

This has no value per se to the system as a whole. But paired with the next PR #113 , it will give better metrics to users. The idea is to have the kuadrant operator populate this with the RLP's name.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #112 (b7cc27a) into main (c4945bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   68.80%   68.80%           
=======================================
  Files          14       14           
  Lines         984      984           
=======================================
  Hits          677      677           
  Misses        267      267           
  Partials       40       40           
Flag Coverage Δ
integration 66.06% <ø> (ø)
unit 70.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <ø> (ø)
pkg/helpers (u) ∅ <ø> (∅)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 44.19% <ø> (ø)
pkg/limitador (u) 88.46% <ø> (ø)
controllers (i) 66.06% <ø> (ø)
Files Coverage Δ
api/v1alpha1/limitador_types.go 100.00% <ø> (ø)

@alexsnaps alexsnaps force-pushed the rlp-named branch 3 times, most recently from e181d99 to fda585e Compare November 8, 2023 13:56
@alexsnaps alexsnaps marked this pull request as ready for review November 8, 2023 14:07
@alexsnaps alexsnaps requested a review from a team November 8, 2023 14:08
@alexsnaps alexsnaps merged commit bb16f15 into main Nov 13, 2023
11 checks passed
@alexsnaps alexsnaps deleted the rlp-named branch November 13, 2023 17:59
@alexsnaps alexsnaps added this to the v0.7.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: To test
Development

Successfully merging this pull request may close these issues.

3 participants