-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello helm #137
Merged
Merged
Hello helm #137
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0b90e9a
[git] Ignoring the right path to the limitador-operator binary
didierofrivia 0fe0fd9
[helm] Initial limitador-operator chart metadata
didierofrivia 362f9e8
[make] Adding `helm` target
didierofrivia ac5748f
[make] Building helm chart templates (manifests)
didierofrivia 9f6e16f
[helm] Default templates/manifests using `latest` tag
didierofrivia dd2da76
[make] Adding install, uninstall and upgrade targets
didierofrivia 068724a
[helm] Default versions for main branch
didierofrivia e070b38
[make] Packaging, uploading and sync
didierofrivia cc8b65a
[workflow] Release workflow
didierofrivia 86ca780
[make] Sertting chart version when building the chart
didierofrivia 0ee0d26
[make] Changing the repository name for helm charts
didierofrivia 851cf39
[refactor] Using `svenstaro/upload-release-action@v2`
didierofrivia a3649ad
[refactor] Renaming the token to match the actual in use one
didierofrivia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: release-helm-chart | ||
on: | ||
# TODO: The following commented lines should be used depending on the release strategy | ||
# release: | ||
# types: | ||
# - released | ||
# OR for a full release workflow | ||
# push: | ||
# tags: | ||
# - 'v*.*.*' | ||
workflow_dispatch: | ||
inputs: | ||
operatorVersion: | ||
description: Operator bundle version | ||
default: 0.0.0 | ||
type: string | ||
limitadorVersion: | ||
description: Limitador version | ||
default: latest | ||
type: string | ||
releaseId: | ||
description: Release ID | ||
default: 0 | ||
type: string | ||
|
||
jobs: | ||
chart_release: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ github.ref }} | ||
fetch-depth: 0 | ||
|
||
- name: Configure Git | ||
run: | | ||
git config user.name "$GITHUB_ACTOR" | ||
git config user.email "[email protected]" | ||
|
||
- name: Build the Helm Chart manifests | ||
run: | | ||
make helm-build \ | ||
VERSION=${{ inputs.operatorVersion }} \ | ||
LIMITADOR_VERSION=${{ inputs.limitadorVersion }} | ||
|
||
- name: Package Helm Chart | ||
run: | | ||
make helm-package | ||
|
||
- name: Upload package to GitHub Release | ||
uses: svenstaro/upload-release-action@v2 | ||
id: upload-chart | ||
with: | ||
repo_token: ${{ secrets.GITHUB_TOKEN }} | ||
file: charts/limitador-operator-${{ inputs.operatorVersion }}.tgz | ||
asset_name: chart-limitador-operator-${{ inputs.operatorVersion }}.tgz | ||
tag: ${{ github.ref }} | ||
overwrite: true | ||
|
||
- name: Sync Helm Chart with repository | ||
run: | | ||
make helm-sync-package \ | ||
VERSION=${{ inputs.operatorVersion }} \ | ||
HELM_WORKFLOWS_TOKEN=${{ secrets.HELM_WORKFLOWS_TOKEN }} \ | ||
BROWSER_DOWNLOAD_URL=${{ steps.upload-chart.outputs.browser_download_url }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
*.so | ||
*.dylib | ||
bin | ||
limitador-operator | ||
/limitador-operator | ||
|
||
# Test binary, build with `go test -c` | ||
*.test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Patterns to ignore when building packages. | ||
# This supports shell glob matching, relative path matching, and | ||
# negation (prefixed with !). Only one pattern per line. | ||
.DS_Store | ||
# Common VCS dirs | ||
.git/ | ||
.gitignore | ||
.bzr/ | ||
.bzrignore | ||
.hg/ | ||
.hgignore | ||
.svn/ | ||
# Common backup files | ||
*.swp | ||
*.bak | ||
*.tmp | ||
*.orig | ||
*~ | ||
# Various IDEs | ||
.project | ||
.idea/ | ||
*.tmproj | ||
.vscode/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
apiVersion: v2 | ||
name: limitador-operator | ||
description: A Helm chart for Limitador Operator | ||
type: application | ||
# The version will be properly set when the chart is released matching the operator version | ||
version: "0.0.0" | ||
maintainers: | ||
- email: [email protected] | ||
name: Alex Snaps | ||
- email: [email protected] | ||
name: Didier Di Cesare | ||
- email: [email protected] | ||
name: Eguzki Astiz Lezaun |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should not be doing this. The git commit (or tag) we are releasing should have done previously
make helm-build
. Any thought?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking it should be part of the building manifests steps just before tagging... However, just a reminder that currently we do that manually before tagging and then let the CI to build the manifests again and publish them to Quay... meaning it's kind of the same in this case, we could run this target and commit it with the rest of the manifests when releasing... but having a separated workflow is convenient when you want to attach charts to other already released operators. What do you reckon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that redundant? What I would do, maybe, it is a test to run (on release event)
make helm-build
and check that no files changed. Same we do withgo generate
ormake bundle
.Not sure I follow.
Anyway, I was not asking for changes actually. Whatever you decide is ok for me on this regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, we'll need to address the redundancy in our workflows, part should be reflected in Kuadrant/architecture#41