Proper impl Ord for Limit
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Snaps <[email protected]>
alexsnaps
commented
Nov 21, 2024
| use std::collections::HashMap; | ||
|
|
||
| #[test] | ||
| fn properly_updates_existing_limits() { |
There was a problem hiding this comment.
This test was "just" to reproduce the None.unwrap(), thought I'd leave it in nonetheless
alexsnaps
changed the title
impl Ord for Limit
eguzki
approved these changes
Nov 21, 2024
| @@ -49,7 +49,7 @@ impl From<String> for Namespace { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Eq, Debug, Clone, PartialOrd, Ord, Serialize, Deserialize)] | |||
| #[derive(Eq, Debug, Clone, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
What was the default PartialOrd and Ord doing instead?
There was a problem hiding this comment.
It uses all the fields in the struct to compare... so it did consider max_value, but also id and name
Signed-off-by: Alex Snaps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Ord for Limitwas out of sync withEq... So looking up counters would fail when navigating theBTreeMap🤦My bad!