This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Refactor endpoint probe check #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
laurafitzgerald
commented
Sep 12, 2023
laurafitzgerald
force-pushed
the
refactor-endpoint-probe-check
branch
from
42034ca to
2d39627
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
mikenairn
reviewed
Sep 13, 2023
mikenairn
reviewed
Sep 13, 2023
mikenairn
reviewed
Sep 13, 2023
mikenairn
reviewed
Sep 13, 2023
laurafitzgerald
force-pushed
the
refactor-endpoint-probe-check
branch
from
2d39627 to
e057a82
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
laurafitzgerald
force-pushed
the
refactor-endpoint-probe-check
branch
from
e057a82 to
6a77786
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
Changes look good to me, can merge after the release is done. 👍 |
laurafitzgerald
force-pushed
the
refactor-endpoint-probe-check
branch
from
6a77786 to
d8191ce
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
/lgtm |
mikenairn
approved these changes
Oct 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A refactor on how we are evaluating endpoints based on health checks
Doing this first and updating the MultiClusterGatewayTarget before attempting to setEndpoints.
Unit tests have been adjusted
No changes required to the integration tests as the functionality here isn't changing, just the approach.
Verification
Follow steps described in #412 as this is a refactor, functionality shouldn't be changed.
Also integration tests covered all cases and those have passed without any change.