This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Watch policies configured by Gateway params #621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioifg94
temporarily deployed
to
e2e-internal
October 10, 2023 10:28 — with
GitHub Actions
Inactive
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sergioifg94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sergioifg94
temporarily deployed
to
e2e-internal
October 10, 2023 15:00 — with
GitHub Actions
Inactive
sergioifg94
temporarily deployed
to
e2e-internal
October 10, 2023 15:04 — with
GitHub Actions
Inactive
👀 |
R-Lawton
reviewed
Oct 11, 2023
Tested locally works as expect saw the logs |
sergioifg94
temporarily deployed
to
e2e-internal
October 12, 2023 08:16 — with
GitHub Actions
Inactive
Thanks @R-Lawton I just pushed a commit with small improvements including the suggestion you made |
/lgtm |
sergioifg94
temporarily deployed
to
e2e-internal
October 13, 2023 08:33 — with
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
policiesToSync
field to the GatewayClass parameters, which allows users to specify GVRs of policies to watchVerification steps
Currently the watch only adds a log message when an event is triggered