Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Add ocp_monitoring sub dir to prometheus-for-federation config #632

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add ocp_monitoring sub dir to prometheus-for-federation config #632

merged 1 commit into from
Oct 19, 2023

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Oct 19, 2023 •
edited
Loading

Requires an OSD or OCP cluster to verify.

Adds all metrics to the user-workload-monitoring in ocp, and a grafana instance with all available dashboards.

jasonmadigan
jasonmadigan approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ran against stitchpoc2, worked fine

config/prometheus-for-federation/ocp_monitoring/README.md Show resolved Hide resolved
config/prometheus-for-federation/ocp_monitoring/kustomization.yaml Outdated Show resolved Hide resolved
@jasonmadigan
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 19, 2023
@david-martin david-martin temporarily deployed to e2e-internal October 19, 2023 09:56 — with GitHub Actions Inactive
@david-martin
Copy link
Member Author

@jasonmadigan removed commented resource.
This is ready for lgtm again

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@openshift-ci openshift-ci bot merged commit fcfb58b into Kuadrant:main Oct 19, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonmadigan jasonmadigan jasonmadigan approved these changes

Assignees

@jasonmadigan jasonmadigan

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-martin @jasonmadigan