This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurafitzgerald
had a problem deploying
to
e2e-internal
October 27, 2023 16:36 — with
GitHub Actions
Failure
laurafitzgerald
had a problem deploying
to
e2e-internal
October 27, 2023 16:39 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
October 27, 2023 16:41
a958013
to
d620ead
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
October 27, 2023 16:41 — with
GitHub Actions
Failure
laurafitzgerald
temporarily deployed
to
e2e-internal
October 31, 2023 09:35 — with
GitHub Actions
Inactive
laurafitzgerald
had a problem deploying
to
e2e-internal
November 2, 2023 12:08 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 2, 2023 12:42
d0477c5
to
f0837da
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 2, 2023 12:42 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 2, 2023 12:54
f0837da
to
373b14c
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 2, 2023 12:54 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 2, 2023 14:16
373b14c
to
b5cc369
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 2, 2023 14:16 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 2, 2023 14:23
b5cc369
to
d9bf29b
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 2, 2023 14:23 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 3, 2023 16:34
d9bf29b
to
4dd23a4
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 3, 2023 16:34 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 3, 2023 16:55
4dd23a4
to
060aa5c
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 3, 2023 16:55 — with
GitHub Actions
Failure
guicassolato
reviewed
Nov 6, 2023
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 7, 2023 16:05
060aa5c
to
f9c4463
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 7, 2023 16:05 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 7, 2023 16:39
f9c4463
to
0759ef6
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 7, 2023 16:40 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 7, 2023 16:59
0759ef6
to
a36aa0e
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 7, 2023 17:00 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 7, 2023 17:07
a36aa0e
to
6b5386c
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
November 7, 2023 17:07 — with
GitHub Actions
Inactive
laurafitzgerald
had a problem deploying
to
e2e-internal
November 10, 2023 15:52 — with
GitHub Actions
Failure
laurafitzgerald
had a problem deploying
to
e2e-internal
November 10, 2023 16:17 — with
GitHub Actions
Failure
laurafitzgerald
had a problem deploying
to
e2e-internal
November 10, 2023 16:54 — with
GitHub Actions
Failure
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 14, 2023 11:15
c74dd23
to
f6d6d03
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
November 14, 2023 11:15 — with
GitHub Actions
Inactive
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 14, 2023 15:06
f6d6d03
to
866597f
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
November 14, 2023 15:06 — with
GitHub Actions
Inactive
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 14, 2023 15:33
866597f
to
7fbb0a4
Compare
laurafitzgerald
had a problem deploying
to
e2e-internal
November 14, 2023 15:33 — with
GitHub Actions
Failure
laurafitzgerald
temporarily deployed
to
e2e-internal
November 14, 2023 15:54 — with
GitHub Actions
Inactive
As discussed we should follow suit and bump the go version to 1.21 Kuadrant/kuadrant-operator@05fe71a. Other than that it all looks good to go 👍 |
Co-authored-by: Sergio France Garcia <[email protected]>
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 15, 2023 17:10
7fbb0a4
to
bc9424a
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
November 15, 2023 17:11 — with
GitHub Actions
Inactive
Co-authored-by: Sergio France Garcia <[email protected]>
laurafitzgerald
force-pushed
the
gh-630
branch
from
November 16, 2023 09:44
bc9424a
to
1e039c7
Compare
laurafitzgerald
temporarily deployed
to
e2e-internal
November 16, 2023 09:44 — with
GitHub Actions
Inactive
Trying this locally, but changes all look good to me. Will also just verify the e2e test still passes with this change #674 so we can get this merged ASAP. |
/hold cancel Verified locally, all working as expected. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald, mikenairn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #630
This is WIP and includes a commit required which also bumps controller-runtime.
Running this requires the use of the kuadrant-operator branch -> Kuadrant/kuadrant-operator@main...laurafitzgerald:kuadrant-operator:gateway-api-v1
There has been some discussion around removing the kuadrant-operator dependency but this will work for now with a temporary commit which points the dependency.
So far e2e tests are passing locally.
Following the multicluster gateway walkthrough
Setting up for the walkthrough can be done via the quickstart and then updates for gateway-api and crds configs using the following commands.
Scale down the gateway-controller pod which comes with the quickstart
kc edit deployment mgc-controller-manager -n multicluster-gateway-controller-system
and change replicas to 0.Scale down the policy-controller pod which comes with the quickstart
kc edit deployment mgc-policy-controller -n multicluster-gateway-controller-system
and change replicas to 0.kustomize build config/istio --enable-helm --helm-command helm | kubectl --context kind-mgc-control-plane apply -f -
kustomize build config/istio --enable-helm --helm-command helm | kubectl --context kind-mgc-workload-1 apply -f -
kustomize build config/gateway-api --enable-helm --helm-command helm | kubectl --context kind-mgc-workload-1 apply -f -
kustomize build config/gateway-api --enable-helm --helm-command helm | kubectl --context kind-mgc-control-plane apply -f -
Run controllers locally from this copy
Follow the steps in the walkthrough.
The walkthrough itself was successful