Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Gh 630 gateway-api v1.0.0 #645

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

laurafitzgerald
Copy link
Contributor

@laurafitzgerald laurafitzgerald commented Oct 27, 2023

Addresses #630

This is WIP and includes a commit required which also bumps controller-runtime.

Running this requires the use of the kuadrant-operator branch -> Kuadrant/kuadrant-operator@main...laurafitzgerald:kuadrant-operator:gateway-api-v1
There has been some discussion around removing the kuadrant-operator dependency but this will work for now with a temporary commit which points the dependency.

So far e2e tests are passing locally.

Following the multicluster gateway walkthrough

Setting up for the walkthrough can be done via the quickstart and then updates for gateway-api and crds configs using the following commands.

Scale down the gateway-controller pod which comes with the quickstart kc edit deployment mgc-controller-manager -n multicluster-gateway-controller-system and change replicas to 0.
Scale down the policy-controller pod which comes with the quickstart kc edit deployment mgc-policy-controller -n multicluster-gateway-controller-system and change replicas to 0.

kustomize build config/istio --enable-helm --helm-command helm | kubectl --context kind-mgc-control-plane apply -f -
kustomize build config/istio --enable-helm --helm-command helm | kubectl --context kind-mgc-workload-1 apply -f -
kustomize build config/gateway-api --enable-helm --helm-command helm | kubectl --context kind-mgc-workload-1 apply -f -
kustomize build config/gateway-api --enable-helm --helm-command helm | kubectl --context kind-mgc-control-plane apply -f -

Run controllers locally from this copy

Follow the steps in the walkthrough.
The walkthrough itself was successful

@laurafitzgerald laurafitzgerald temporarily deployed to e2e-internal October 31, 2023 09:35 — with GitHub Actions Inactive
@mikenairn
Copy link
Member

As discussed we should follow suit and bump the go version to 1.21 Kuadrant/kuadrant-operator@05fe71a.

Other than that it all looks good to go 👍

Co-authored-by: Sergio France Garcia <[email protected]>
laurafitzgerald and others added 2 commits November 16, 2023 09:44
@mikenairn
Copy link
Member

Trying this locally, but changes all look good to me. Will also just verify the e2e test still passes with this change #674 so we can get this merged ASAP.

@mikenairn
Copy link
Member

/hold cancel

Verified locally, all working as expected.

@mikenairn
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f93bb55 into Kuadrant:main Nov 16, 2023
9 checks passed
@sergioifg94 sergioifg94 mentioned this pull request Nov 16, 2023
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants