controller: coallescing of sotw cache subscription events #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Boomatang
reviewed
Sep 30, 2024
Signed-off-by: Guilherme Cassolato <[email protected]>
KevFan
reviewed
Sep 30, 2024
Signed-off-by: Guilherme Cassolato <[email protected]>
KevFan
reviewed
Sep 30, 2024
KevFan
reviewed
Sep 30, 2024
guicassolato
force-pushed
the
single-watchable-cache-entry
branch
from
6102fc5 to
0cc0687
Compare
Signed-off-by: Guilherme Cassolato <[email protected]>
guicassolato
force-pushed
the
single-watchable-cache-entry
branch
from
0cc0687 to
4beba76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make replacing the state of the cache atomic for full lists of resources, so only one message is written to the internal channel before propagation by the controller instead of one message per resource.
This will cause the sotw reconciler to pick up and propagte one single reconciliation call for each state of the world, instead of mimicking the traditional controller-runtime approach of more or less one call per cluster event.