Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: do not propagate meaningless cache events #41

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

guicassolato
Copy link
Contributor

Do not propagate cache events when there were no updates to the snapshot. This usually happens when the cache is first initialised, causing an empty topology to be built due to resources not having been listed yet.

@guicassolato guicassolato force-pushed the do-not-propagate-no-event branch from 8cc4b4b to ee6fcfe Compare October 4, 2024 13:20
@guicassolato guicassolato marked this pull request as ready for review October 4, 2024 13:20
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@guicassolato guicassolato merged commit 72b15c6 into main Oct 4, 2024
13 checks passed
@guicassolato guicassolato deleted the do-not-propagate-no-event branch October 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants