-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic objects to the topology #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
force-pushed
the
topology-objects
branch
from
July 12, 2024 08:15
bea73a5
to
04f23e5
Compare
guicassolato
force-pushed
the
topology-objects
branch
from
July 12, 2024 08:17
04f23e5
to
08c079e
Compare
…ind of runtime object
…avigated for generic objects The listing functions Targetables(filters...) and Policies(filters...) have been modified to now return pointers to collections of that type, that can be navigated through the graph methods Roots(), Parents(), Children(), and Paths(). + makes policies linkable.
guicassolato
force-pushed
the
topology-objects
branch
from
July 15, 2024 14:55
d30ab10
to
3a5fa0e
Compare
guicassolato
force-pushed
the
topology-objects
branch
from
July 15, 2024 15:51
3a5fa0e
to
7eca994
Compare
guicassolato
force-pushed
the
topology-objects
branch
from
July 15, 2024 16:06
7eca994
to
c60d200
Compare
KevFan
reviewed
Jul 19, 2024
guicassolato
force-pushed
the
topology-objects
branch
from
July 19, 2024 19:18
b240462
to
be05449
Compare
guicassolato
force-pushed
the
topology-objects
branch
from
July 19, 2024 19:18
be05449
to
ef27561
Compare
KevFan
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified envoy-gateway.md
and multiple-gateway-providers.md
and both are working as expected.
Looks good to me! 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the
Topology
struct (mainly) to better support generic objects added to the graph.In general, allows creating and navigating topologies such as the following:
Targetables(filters...)
andPolicies(filters...)
have been modified to now return pointers to collections of that type, that can be navigated through the graph methodsRoots()
,Parents()
,Children()
, andPaths()
topology.Objects().Children(gateway)
to return all generic objects that are children of the gateway (targetable)Object
struct (previouslygenericObject
) – for easy wrapping of any runtime object kindDestruct
- to create and and update objects from concrete typesRestructure
function – for consistency withDestruct
(also public)Store
– so access to the objects can be given to build runtime link functions