controller: reconciliation workflows #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces new reconciler abstractions `Dispatcher` and `Subscriber`:
* `Dispatcher`: runs an optional precondition reconciliation function and then dispatches the reconciliation event to a list of subsequent reconcilers.
* `Subscriber`: calls the reconciler function of the first subscription that matches the event
Additionally:
- controller topology was also simplified: no longer stored with the controller, since it's currently being rebuilt at every event (this can change in the future)
- propagation of a new ResourceEvent struct through reconciliation calls: stores info about the API resource, event type (create/update/delete), old and new objects
- kuadrant controller example updated to leverage the changes above:
- new reconciliation workflow:
1. log event
2. save topology to file
3. effective policies
4. (gateway deleted) delete SecurityPolicy / (other events) reconcile SecurityPolicies
4. (gateway deleted) delete AuthorizationPolicy / (other events) reconcile AuthorizationPolicies
- reconcilers moved to an internal package examples/kuadrant/reconcilers
- docs: envoy gateway and multiple gateway providers docs moved to examples/kuadrant/docs
- fix bug in the build of Istio AuthorizationPolicy rules: missing HTTPRoute hostnames
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
KevFan
reviewed
Jul 25, 2024
KevFan
reviewed
Jul 25, 2024
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
KevFan
reviewed
Jul 29, 2024
| gwapiv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2" | ||
|
|
||
| "github.com/kuadrant/policy-machinery/machinery" | ||
|
|
||
| kuadrantapis "github.com/kuadrant/policy-machinery/examples/kuadrant/apis" | ||
| ) | ||
|
|
||
| var ( | ||
| RateLimitPolicyKind = schema.GroupKind{Group: SchemeGroupVersion.Group, Kind: "RateLimit"} |
There was a problem hiding this comment.
Suggested change
| RateLimitPolicyKind = schema.GroupKind{Group: SchemeGroupVersion.Group, Kind: "RateLimit"} | |
| RateLimitPolicyKind = schema.GroupKind{Group: SchemeGroupVersion.Group, Kind: "RateLimitPolicy"} |
There was a problem hiding this comment.
Time to start writing tests 😜
Signed-off-by: Guilherme Cassolato <[email protected]>
KevFan
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new reconciler abstractions
WorkflowandSubscriber:Workflow: runs an optional precondition reconciliation function, then dispatches the reconciliation event to a list of concurrent reconciliation tasks, and runs an optional postcondition reconciliation function.Subscriber: calls the reconciler function of the first subscription that matches the event (resource, event type, object name)Additionally:
examples/kuadrant/reconcilersexamples/kuadrant/docs